fix(files_reminder): passed reminder handling - #59228
Merged
Merged
Conversation
skjnldsv
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
March 26, 2026 13:03
skjnldsv
requested review from
CarlSchwan and
leftybournes
and removed request for
a team
March 26, 2026 13:03
Member
Author
|
/backport to stable33 |
skjnldsv
force-pushed
the
fix/reminder-past
branch
from
March 26, 2026 13:18
a85e455 to
bb962d6
Compare
skjnldsv
force-pushed
the
fix/reminder-past
branch
from
March 26, 2026 13:24
bb962d6 to
cc7c56c
Compare
Member
Author
|
/compile rebase |
nextcloud-command
force-pushed
the
fix/reminder-past
branch
from
March 26, 2026 14:56
cc7c56c to
786d3f2
Compare
| const relativeDueDate = formatRelativeTime(customDueDate.value ?? 0) | ||
| return (nowDate.value.getTime() >= (customDueDate.value?.getTime() ?? 0)) | ||
| // TRANSLATORS: {relativeDueDate} will be replaced with a relative time, e.g. "2 hours ago" or "in 3 days". | ||
| ? t('files_reminders', 'We reminded you of this file {relativeDueDate}', { relativeDueDate }) |
Member
There was a problem hiding this comment.
I don't understand the purpose of this "historical reminder" message. Is it just a fallback for stale paths and/or triggering test(s)?
Do we intentionally want the modal to present past reminders as historical state when they slip through, or should it instead behave as if no reminder exists?
Member
Author
There was a problem hiding this comment.
No, it's just that we don't handle the passed reminders logic on the front-end. The backend does it now. So I'm making the front compliant to whatever data.
It's more like a failsafe.
skjnldsv
enabled auto-merge
March 30, 2026 06:30
skjnldsv
force-pushed
the
fix/reminder-past
branch
from
April 1, 2026 07:58
90e8b39 to
fdde361
Compare
Member
Author
|
/compile rebase |
nextcloud-command
force-pushed
the
fix/reminder-past
branch
from
May 12, 2026 13:48
fdde361 to
66264a8
Compare
Merged
Closed
Contributor
|
/compile rebase |
susnux
approved these changes
Aug 19, 2026
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/reminder-past
branch
from
August 19, 2026 15:52
66264a8 to
ee553fa
Compare
3 tasks
Contributor
|
/backport to stable34 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR solved two logic issues
Checklist
3. to review, feature component)stable32)AI (if applicable)